Clik here to view.
UX: Better composer hyperlink modal (PR #8160)
@pmusaraj wrote: This brings the hyperlink modal in line with all other modals (upload, date, etc.) by placing the fixed modal element outside of the composer. Before: After: GitHub Read full topic
View ArticleUX: Better composer hyperlink modal (PR #8160)
@discoursebot wrote: You’ve signed the CLA, pmusaraj. Thank you! This pull request is ready for review. Read full topic
View ArticleUX: Better composer hyperlink modal (PR #8160)
@CvX1 wrote: app/assets/javascripts/discourse/controllers/insert-hyperlink.js.es6 @@ -0,0 +1,50 @@ +import ModalFunctionality from "discourse/mixins/modal-functionality"; +import { default as computed...
View ArticleUX: Better composer hyperlink modal (PR #8160)
@pmusaraj wrote: Good spot, no, it doesn’t need to be computed at all. Read full topic
View ArticleUX: Better composer hyperlink modal (PR #8160)
@CvX1 wrote: app/assets/javascripts/discourse/controllers/insert-hyperlink.js.es6 @@ -0,0 +1,47 @@ +import ModalFunctionality from "discourse/mixins/modal-functionality"; +import { default as computed...
View ArticleUX: Better composer hyperlink modal (PR #8160)
@SamSaffron wrote: I support this cleanup, feel free to merge! Read full topic
View ArticleUX: Better composer hyperlink modal (PR #8160)
@CvX1 wrote: @pmusaraj It seems it’s no longer possible to submit the form by pressing enter/return. Could this PR be the cause? Read full topic
View ArticleUX: Better composer hyperlink modal (PR #8160)
@pmusaraj wrote: Yes, it’s possible. I think our modals in general do not submit on return, I think we should fix that globally. Read full topic
View ArticleUX: Better composer hyperlink modal (PR #8160)
@pmusaraj wrote: UX: Trigger primary action in modals using Enter should fix your issue @CvX. Read full topic
View Article
